Skip to content

Fix : [ISSUE] databricks auth login - Invalid Databricks Account configuration when host does not specify scheme #1403 #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix : [ISSUE] databricks auth login - Invalid Databricks Account configuration when host does not specify scheme #1403 #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38af645
Fix : [ISSUE] databricks auth login - Invalid Databricks Account conf…
lakshiya Mar 30, 2025
2c1896a
Fix : [ISSUE] databricks auth login - Invalid Databricks Account conf…
lakshiya Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,8 @@ func (c *Config) IsAccountClient() bool {
accountsPrefixes := []string{
"https://accounts.",
"https://accounts-dod.",
"accounts.",
"accounts-dod.",
}
for _, prefix := range accountsPrefixes {
if strings.HasPrefix(c.Host, prefix) {
Expand Down
16 changes: 16 additions & 0 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,22 @@ func TestIsAccountClient_AwsAccount(t *testing.T) {
assert.True(t, c.IsAccountClient())
}

func TestIsAccountClient_WithoutHTTPSInHost_AWSAccount(t *testing.T) {
c := &Config{
Host: "accounts.cloud.databricks.com",
AccountID: "123e4567-e89b-12d3-a456-426614174000",
}
assert.True(t, c.IsAccountClient())
}

func TestIsAccountClient_WithoutHTTPSInHost_AwsDodAccount(t *testing.T) {
c := &Config{
Host: "accounts-dod.cloud.databricks.us",
AccountID: "123e4567-e89b-12d3-a456-426614174000",
}
assert.True(t, c.IsAccountClient())
}

func TestIsAccountClient_AwsDodAccount(t *testing.T) {
c := &Config{
Host: "https://accounts-dod.cloud.databricks.us",
Expand Down
Loading