Fix selectSparkVersion() when sparkVersion is provided #229
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing an exact match instead of a contains. The API doesn't return the result in the format that matches the current clause
|
Thanks for raising this! Can you add a unit test to ClustersExtTest to test this behavior? Otherwise this is fine. |
mgyucht
added a commit
that referenced
this pull request
Aug 25, 2025
The current implementation of selectSparkVersion() was broken when sparkVersion is supplied. The code was requiring an exact match instead of using contains(), which never matched real Databricks Runtime version names like "12.2 LTS (includes Apache Spark 3.3.2, Scala 2.12)". This change aligns the Java SDK with the Go and Python SDK implementations, which both use contains()/in operations for sparkVersion matching. Fixes the issue described in PR #229. Added comprehensive unit tests covering: - Successful spark version matching with realistic API response data - Multiple matches with latest=true/false behavior - Integration with other selector parameters (ML, etc.) - Error cases for non-existent versions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 27, 2025
## What changes are proposed in this pull request? This PR fixes a bug in the `selectSparkVersion()` method in `ClustersExt.java` where spark version matching doesn't work with real Databricks Runtime version names. The current `equals()` implementation fails because real Databricks Runtime version names contain additional information. For example, the actual version name is `"13.3 LTS (includes Apache Spark 3.4.1, Scala 2.12)"`, not just `"Apache Spark 3.4.1"`. Both the Go SDK (`strings.Contains()`) and Python SDK (`in` operator) use substring matching for this functionality. Originally reported in PR #229 with real API response data. ## How is this tested? Added a focused unit test `sparkVersionWithSparkVersionParameter()` that demonstrates the fix works with realistic API response data. The test uses a version name in the actual format returned by the Databricks API: `"13.3 LTS (includes Apache Spark 3.4.1, Scala 2.12)"`. Fixes #229 --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The current implementation of selectSparkVersion() is broken when
sparkVersionis supplied. This is due to the code requiring an exact match instead of a contains.The referenced Go code it was copied from uses contains not equals as well, and when you check the returned payload you can see it would not currently find any matching spark versions.
Tests
Ran unit tests