Remove unified flag usage and fix tests for server-side OIDC resolution#1331
Open
hectorcast-db wants to merge 10 commits intomainfrom
Open
Remove unified flag usage and fix tests for server-side OIDC resolution#1331hectorcast-db wants to merge 10 commits intomainfrom
hectorcast-db wants to merge 10 commits intomainfrom
Conversation
Update test_config.py to reflect that OIDC endpoint selection is now handled server-side via host metadata. Add per-test HostMetadata overrides where needed, remove tests that were just round-tripping mocked metadata, and delete tests for removed unified flag behavior. Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
changed the title
hectorcast-db
changed the title
…orkspace_id Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
The host metadata oidc_endpoint is the OIDC root, not the full discovery URL. Append the well-known path when constructing discovery_url, and strip trailing slashes to avoid double slashes. Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…orkspace_id Verifies that Config with experimental_is_unified_host resolves account_id and workspace_id from the host metadata endpoint. Co-authored-by: Isaac
Add vscode_pytest module check so _load_debug_env_if_runs_from_ide works when running tests from Cursor/VS Code, not just JetBrains. Co-authored-by: Isaac
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
commented
Mar 13, 2026
| if audience is None and cfg.client_type == ClientType.ACCOUNT: | ||
| audience = cfg.account_id | ||
| if audience is None and cfg.client_type != ClientType.ACCOUNT: | ||
| if audience is None: |
Contributor
Author
There was a problem hiding this comment.
For account level hosts, audience is set during host metadata resolution.
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Remove the two CLI token source tests that asserted the flag was passed, as we are dropping --experimental-is-unified-host from the CLI args. Co-authored-by: Isaac
hectorcast-db
force-pushed
the
hectorcast-db/stack/unified-for-real
branch
from
fbfa4cc to
a9af8c6
Compare
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
experimental_is_unified_hostflag andClientType.UNIFIEDusages — all hosts now go through the same metadata resolution pathdatabricks_oidc_endpointsto usediscovery_urlfrom host metadata instead of client-side URL constructionHostMetadataoverrides for tests that need a validdiscovery_urlis_account_clientno longer raises on unified hosts)NOTE: This PR does not remove yet the flag itself, since the feature is still on experimental mode.
Test plan
test_databricks_oidc_endpoints_uses_discovery_url)This pull request was AI-assisted by Isaac.