Skip to content

Clean Up Stale Clean Room Artifacts #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clean Up Stale Clean Room Artifacts #5072

wants to merge 1 commit into from

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Oct 2, 2025

Changes

This PR removes all resources, data sources, and documentation related to Clean Room services.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework
  • has entry in NEXT_CHANGELOG.md file

@rauchy rauchy requested review from a team as code owners October 2, 2025 07:03
@rauchy rauchy requested review from renaudhartert-db and removed request for a team October 2, 2025 07:03
@rauchy rauchy temporarily deployed to test-trigger-is October 2, 2025 07:03 — with GitHub Actions Inactive
@rauchy rauchy temporarily deployed to test-trigger-is October 2, 2025 07:04 — with GitHub Actions Inactive
@rauchy rauchy force-pushed the omer-lachish_data/clean-room-cleanup branch from df79bed to b93f6bd Compare October 2, 2025 07:04
@rauchy rauchy temporarily deployed to test-trigger-is October 2, 2025 07:04 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 5072
  • Commit SHA: b93f6bdbb60616b740e1120c639769d69f232c69

Checks will be approved automatically on success.

@rauchy rauchy temporarily deployed to test-trigger-is October 2, 2025 07:05 — with GitHub Actions Inactive
alexott
alexott requested changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, but we need to mark it as a breaking change because we already have 2 customers who use them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott requested changes

@mgyucht mgyucht mgyucht approved these changes

@renaudhartert-db renaudhartert-db Awaiting requested review from renaudhartert-db renaudhartert-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rauchy @alexott @mgyucht