[Internal] Use TEST_ENVIRONMENT_TYPE for acceptance test environment detection - #5476
Merged
Conversation
tanmay-db
temporarily deployed
to
test-trigger-is
March 11, 2026 18:04 — with
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
March 11, 2026 18:05 — with
GitHub Actions
Inactive
…ricks into move-away-acc-id
tanmay-db
temporarily deployed
to
test-trigger-is
March 17, 2026 13:14 — with
GitHub Actions
Inactive
tanmay-db
marked this pull request as ready for review
March 17, 2026 13:15
tanmay-db
requested review from
mihaimitrea-db
and removed request for
a team and
mihaimitrea-db
March 17, 2026 13:15
tanmay-db
temporarily deployed
to
test-trigger-is
March 17, 2026 13:15 — with
GitHub Actions
Inactive
…ricks into move-away-acc-id
…ricks into move-away-acc-id
tanmay-db
temporarily deployed
to
test-trigger-is
March 26, 2026 09:57 — with
GitHub Actions
Inactive
tanmay-db
temporarily deployed
to
test-trigger-is
March 26, 2026 09:57 — with
GitHub Actions
Inactive
|
|
||
| func LoadWorkspaceEnv(t *testing.T) { | ||
| initTest(t, "workspace") | ||
| if os.Getenv("DATABRICKS_ACCOUNT_ID") != "" { |
Contributor
There was a problem hiding this comment.
I think tthat here we want to run it in both WORKSPCE and UC_WORKSPACE. That is the current behavior.
…ovider-databricks into move-away-acc-id
tanmay-db
temporarily deployed
to
test-trigger-is
March 26, 2026 10:45 — with
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
tanmay-db
temporarily deployed
to
test-trigger-is
March 26, 2026 10:46 — with
GitHub Actions
Inactive
hectorcast-db
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
DATABRICKS_ACCOUNT_ID,TEST_METASTORE_ID) with a singleTEST_ENVIRONMENT_TYPEvariable for determining test execution contextskipIfNotEnvironmentType()helper that centralizes skip logic for all four test levels:ACCOUNT,WORKSPACE,UC_ACCOUNT,UC_WORKSPACELoadWorkspaceEnv,LoadAccountEnv,LoadUcwsEnv, andLoadUcacctEnvto one-linersTests
NO_CHANGELOG=true