Make Airflow plugin fully compatible with Airflow (WIP: partial changes) #14482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r imports in the listener
…ratorlineage objects, linted
github-actions
bot
added
ingestion
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| dagrun: "DagRun" = task_instance.dag_run # type: ignore[attr-defined] | ||
| task = task_instance.task | ||
| if TYPE_CHECKING: | ||
| assert task |
There was a problem hiding this comment.
Dangerous use of assert - low severity
When running Python in production in optimized mode, assert calls are not executed. This mode is enabled by setting the PYTHONOPTIMIZE command line flag. Optimized mode is usually ON in production. Any safety check done using assert will not be executed.
Remediation: Raise an exception instead of using assert.
View details in Aikido Security
Bundle ReportChanges will decrease total bundle size by 6.24MB (-21.9%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
datahub-cyborg
bot
added
the
needs-review
harishkesavarao
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the series of PRs for #13357.
@hsheth2 opening this to get early feedback from you and others on the general approach, especially for the extractor design.
If you all think that the overall design looks good, I can expand this to on_task_instance_failed and the DAG methods.
(some aspects of the integration tests are failing, currently fixing them)