Skip to content

Conversation

v-tarasevich-blitz-brain
Copy link
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented Aug 18, 2025

This PR brings changes from Saas repo

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Aug 18, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Aug 18, 2025
Copy link

alwaysmeticulous bot commented Aug 18, 2025

✅ Meticulous spotted 0 visual differences across 1401 screens tested: view results.

Meticulous evaluated ~9 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 8ce3ff8. This comment will update as new commits are pushed.

Copy link

codecov bot commented Aug 18, 2025

Bundle Report

Changes will increase total bundle size by 3.09kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.49MB 3.09kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 3.09kB 18.84MB 0.02%

Files in assets/index-*.js:

  • ./src/app/homeV3/modules/hierarchyViewModule/components/domains/hooks/useSelectableDomainTree.ts → Total Size: 2.37kB

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/components/itemsLoaderWrapper/NodesLoaderByButtonWrapper.tsx → Total Size: 823 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/domains/hooks/useRootDomains.ts → Total Size: 80 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/context/TreeViewContextProvider.tsx → Total Size: 9.01kB

  • ./src/app/homeV3/modules/hierarchyViewModule/childrenLoader/context/ChildrenLoaderProvider.tsx → Total Size: 963 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/domains/DomainsSelectableTreeView.tsx → Total Size: 2.61kB

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/components/Row.tsx → Total Size: 124 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/components/itemsLoaderWrapper/NodesLoaderInfiniteScrollWrapper.tsx → Total Size: 974 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/TreeNodeRenderer.tsx → Total Size: 3.9kB

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/components/itemsLoaderWrapper/NodesLoaderWrapper.tsx → Total Size: 484 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/TreeNodesRenderer.tsx → Total Size: 1.26kB

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/context/TreeViewContext.tsx → Total Size: 961 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/domains/hooks/useDomains.ts → Total Size: 1.18kB

  • ./src/app/homeV3/modules/hierarchyViewModule/childrenLoader/context/ChildrenLoaderContext.ts → Total Size: 228 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/components/TreeNodesViewLoader.tsx → Total Size: 447 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/components/domains/hooks/useLoadMoreRootDomains.ts → Total Size: 1.49kB

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/constants.ts → Total Size: 34 bytes

  • ./src/app/homeV3/modules/hierarchyViewModule/treeView/utils.ts → Total Size: 4.12kB

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 40.94488% with 75 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...components/domains/hooks/useLoadMoreRootDomains.ts 10.52% 51 Missing ⚠️
...yViewModule/components/domains/hooks/useDomains.ts 25.00% 15 Missing ⚠️
...omponents/domains/hooks/useSelectableDomainTree.ts 80.00% 8 Missing ⚠️
...wModule/components/domains/hooks/useRootDomains.ts 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (40.94%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@chriscollins3456
Copy link
Collaborator

looks like we have a conflict on this bad boy but otherwise should be solid

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Aug 20, 2025
@chriscollins3456 chriscollins3456 merged commit 8234cbe into master Aug 22, 2025
33 of 35 checks passed
@chriscollins3456 chriscollins3456 deleted the vt--hierarchy-module--add-infinite-scrolling-to-root-level branch August 22, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-response Issue/request has been reviewed but requires a response from the submitter product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants