-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Added toggle gradient and cleaned up the size #14518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔴 Meticulous spotted visual differences in 52 of 1395 screens tested: view and approve differences detected. Meticulous evaluated ~8 hours of user flows against your PR. Last updated for commit 8968b2f. This comment will update as new commits are pushed. |
Bundle ReportChanges will decrease total bundle size by 817 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (34.61%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
left: getIconTransformPositionLeft(size, checked || false), | ||
top: getIconTransformPositionTop(size), | ||
({ checked }) => ({ | ||
left: checked ? '15px' : '1px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would the left offset be dependent on the size? were you able to test this for different sizes?
switch.mov@jayacryl please take another look |
@@ -32,40 +25,41 @@ export const SwitchContainer = styled.label<{ labelPosition: SwitchLabelPosition | |||
); | |||
|
|||
export const Slider = styled.div<{ size?: SizeOptions; isSquare?: boolean; isDisabled?: boolean }>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size isn't used anymore right? should we remove that prop?
I would just:
|
closed and made a way more targeted approach: #14545 |
Before:

After:

switch.mov