Skip to content

Conversation

@purnimagarg1
Copy link
Collaborator

Linear tickets:
https://linear.app/acryl-data/issue/CH-699/underline-and-font-size-do-not-get-saved-in-rich-text-editor
https://linear.app/acryl-data/issue/CH-700/reduce-the-size-of-icons-in-rich-text-editor-toolbar

Description:

Underline and font-size were both appearing visually in the rich text editor, but were not rendering after save. This PR handles that situation. It also, updates styles and sizes in the editor toolbar

Screenshots:

image

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 21, 2025

✅ Meticulous spotted visual differences in 8 of 1351 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit c4d350b. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Aug 21, 2025
@codecov
Copy link

codecov bot commented Aug 21, 2025

Bundle Report

Changes will increase total bundle size by 672 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.51MB 672 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 672 bytes 18.86MB 0.0%

Files in assets/index-*.js:

  • ./src/alchemy-components/components/Editor/toolbar/FontSizeSelect.tsx → Total Size: 889 bytes

  • ./src/alchemy-components/components/Editor/extensions/htmlToMarkdown.tsx → Total Size: 3.55kB

  • ./src/alchemy-components/components/Editor/toolbar/Toolbar.tsx → Total Size: 3.68kB

  • ./src/alchemy-components/components/Editor/utils.ts → Total Size: 58 bytes

@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Base automatically changed from pg--ch-673-documentation-editor-summary-tab to master August 25, 2025 14:26
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice this is looking pretty reasonable

@chriscollins3456 chriscollins3456 merged commit d1c36b2 into master Aug 27, 2025
35 checks passed
@chriscollins3456 chriscollins3456 deleted the ch-699-ch-700-rich-text-editor-improvements branch August 27, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants