-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improvement(ui): save underline and font-size from rich text editor and improve styles #14525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement(ui): save underline and font-size from rich text editor and improve styles #14525
Conversation
|
✅ Meticulous spotted visual differences in 8 of 1351 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit c4d350b. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 672 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chriscollins3456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice this is looking pretty reasonable
Linear tickets:
https://linear.app/acryl-data/issue/CH-699/underline-and-font-size-do-not-get-saved-in-rich-text-editor
https://linear.app/acryl-data/issue/CH-700/reduce-the-size-of-icons-in-rich-text-editor-toolbar
Description:
Underline and font-size were both appearing visually in the rich text editor, but were not rendering after save. This PR handles that situation. It also, updates styles and sizes in the editor toolbar
Screenshots: