Skip to content

Conversation

purnimagarg1
Copy link
Collaborator

@purnimagarg1 purnimagarg1 commented Oct 7, 2025

Linear ticket:
https://linear.app/acryl-data/issue/PRD-2299/add-new-platforms-default-module-to-home-page

Description:
This PR adds a new module for showing platforms. It also adds platforms module as a default module on the homepage.

Screenshot:

image image

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Oct 7, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 7, 2025
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

alwaysmeticulous bot commented Oct 7, 2025

🔴 Meticulous spotted visual differences in 5 of 993 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 2df6fd4. This comment will update as new commits are pushed.

Copy link

codecov bot commented Oct 7, 2025

Bundle Report

Changes will increase total bundle size by 2.04kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.59MB 2.04kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 2.04kB 18.93MB 0.01%

Files in assets/index-*.js:

  • ./src/app/homeV3/modules/platforms/PlatformsModule.tsx → Total Size: 1.85kB

  • ./src/app/searchV2/autoCompleteV2/AutoCompleteEntityItem.tsx → Total Size: 5.65kB

  • ./src/app/homeV3/module/Module.tsx → Total Size: 1.57kB

  • ./src/app/homeV3/module/components/EntityItem.tsx → Total Size: 1.79kB

  • ./src/app/homeV2/content/tabs/discovery/sections/platform/useGetPlatforms.tsx → Total Size: 952 bytes

  • ./src/app/homeV3/template/components/addModuleMenu/useAddModuleMenu.tsx → Total Size: 10.01kB

  • ./src/app/homeV3/modules/platforms/usePlatformsModuleUtils.ts → Total Size: 476 bytes

  • ./src/app/homeV3/modules/constants.ts → Total Size: 2.75kB


- name: page-templates
version: v3
version: v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to think about this is necessary for OSS or not..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's revert this and not update the version

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 8, 2025
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Oct 8, 2025
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looking solid, just a few questions around props to AutoCompleteEntityItem and making sure we do send analytics for this module!

<DisplayNameHoverComponent
let displayNameContent;

if (customOnClick) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm a little confused why this is needed - i see EntityItem has this and we pass customOnClick down here, but why do both need that?

i also see we pass in onClick={sendAnalytics} from EntityItem but that wouldn't get used if we have a custom on click right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i do think we want to send analytics here so we know what module is being interacted with like we do for other modules

Comment on lines 225 to 227
{customHover ? (
customHover(entity, <DisplayNameWrapper>{displayNameContent}</DisplayNameWrapper>)
) : (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah and same thing - do we need custom hover? maybe

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants