feat(uploadFiles): add endpoint to get presigned upload url #14943
+1,486
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
v-tarasevich-blitz-brain
force-pushed
the
vt--ch-820-upload-files--add-upload-method
branch
from
3d2e071 to
629229b
Compare
Bundle ReportChanges will increase total bundle size by 2.14kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
anshbansal
reviewed
Oct 13, 2025
...rc/main/java/com/linkedin/datahub/graphql/resolvers/files/GetPresignedUploadUrlResolver.java
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
the
needs-review
...rc/main/java/com/linkedin/datahub/graphql/resolvers/files/GetPresignedUploadUrlResolver.java
Show resolved
Hide resolved
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java
Outdated
Show resolved
Hide resolved
| this(s3Client, entityClient, null); | ||
| } | ||
|
|
||
| public S3Util( |
There was a problem hiding this comment.
let's double check @anshbansal has reviewed this file since he was the original implementer
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/util/S3Util.java
Show resolved
Hide resolved
datahub-cyborg
bot
added
pending-submitter-response
datahub-cyborg
bot
added
needs-review
v-tarasevich-blitz-brain
changed the title
datahub-cyborg
bot
added
pending-submitter-response
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/util/S3Util.java
Outdated
Show resolved
Hide resolved
metadata-service/factories/src/test/java/com/linkedin/gms/factory/s3/S3UtilFactoryTest.java
Outdated
Show resolved
Hide resolved
datahub-cyborg
bot
added
needs-review
datahub-cyborg
bot
added
pending-submitter-response
chriscollins3456
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
overall this is looking solid to me. I'd like to double check with @david-leifker to get sign off, and @anshbansal who originally implemented the S3Util file
datahub-cyborg
bot
added
pending-submitter-merge
and removed
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: