-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(structured-properties): implement infinite scroll with backend search for structured properties table #14991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(structured-properties): implement infinite scroll with backend search for structured properties table #14991
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
🔴 Meticulous spotted visual differences in 60 of 1075 screens tested: view and approve differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 0634b8e. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 783 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Linear tickets:
https://linear.app/acryl-data/issue/CH-811/implement-infinite-scroll-in-structured-properties-table
https://linear.app/acryl-data/issue/CH-813/update-the-search-functionality-in-structured-properties-to-do-a
Description:
This PR adds support for infinite scroll in tables with
TableWithInfiniteScroll
inside Table folder in components.It then implements TableWithInfiniteScroll in structured properties.
It also changes the search implementation for structured properties to use backend search. It implements
autocomplete
on structured property entities and uses that for search. So,autoCompleteResults
query (max 200 items) is used for search andsearchResultsForMultipleQuery
is used for fetching properties (without search) with infinite scroll.It also handles the way immediate feedback is shown to the user. Instead of using cache, we now handle it inside
useInfiniteScroll
hook (keeping it generic) and update the states to show immediate feedback after add, remove and update of structured properties.Video:
Screen.Recording.2025-10-14.at.5.38.45.PM.mov