-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(ui) Add new file upload to S3 extension in the UI #15004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cc--ch-823-download-rest-endpoint
Are you sure you want to change the base?
feat(ui) Add new file upload to S3 extension in the UI #15004
Conversation
✅ Meticulous spotted 0 visual differences across 950 screens tested: view results. Meticulous evaluated ~9 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 9367e7d. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 8.25kB (0.03%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
removeEditingParam(); | ||
}; | ||
|
||
const { uploadFile } = useFileUpload({ scenario: UploadDownloadScenario.AssetDocumentation, assetUrn }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somewhere we have to add checking of our feature flag to enable/disable uploading
url.includes('amazonaws.com') || // Other AWS storage | ||
url.includes('storage.googleapis.com') || // Google Cloud Storage | ||
url.includes('blob.core.windows.net') || // Azure Blob Storage | ||
url.match(/\.(pdf|doc|docx|xls|xlsx|ppt|pptx|txt|jpg|jpeg|png|gif|webp|mp4|mp3|zip|rar)$/i) !== null // File extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we generate the pattern from EXTENSION_TO_FILE_TYPE to keep them in sync?
This PR builds a new extension that allows us to drag and drop files into our rich text
Editor
component and upload them to S3, completing the desired flow of requesting a presigned URL, uploading to S3, then rendering a classic markdown link/image with a reference to our own file service REST API (what this PR is built on top of).Right now this is only enabled on the new summary tab, but we have another PR coming out where we can support this for all entity documentation and extend support elsewhere as well.
Screen.Recording.2025-10-14.at.12.49.30.PM.mov