Skip to content

Conversation

sgomezvillamor
Copy link
Contributor

@sgomezvillamor sgomezvillamor commented Oct 14, 2025

Summary

  • Removes deprecated SqlParsingBuilder - legacy/deprecated code with no tests
  • Migrates Unity catalog to SqlParsingAggregator - strategic solution used across all other SQL sources
    • Enhances Unity catalog lineage with better column-level details and transform operations

Benefits

  • Better lineage: Unity catalog now gets transform operations and confidence scores
  • Consistency: All SQL sources now use the same strategic SqlParsingAggregator
  • Maintenance: Removed untested legacy code

🤖 Generated with Claude Code

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 14, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 14, 2025
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

alwaysmeticulous bot commented Oct 14, 2025

✅ Meticulous spotted 0 visual differences across 996 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit a9b8a18. This comment will update as new commits are pushed.

Copy link

codecov bot commented Oct 14, 2025

Bundle Report

Bundle size has no change ✅

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Oct 16, 2025
@sgomezvillamor sgomezvillamor changed the title chore: migrate Unity catalog from deprecated SqlParsingBuilder to SqlParsingAggregator chore: migrate Unity catalog from deprecated SqlParsingBuilder to SqlParsingAggregator and remove SqlParsingBuilder Oct 16, 2025
@sgomezvillamor sgomezvillamor enabled auto-merge (squash) October 16, 2025 13:46
@sgomezvillamor sgomezvillamor merged commit b3d354b into master Oct 16, 2025
62 of 63 checks passed
@sgomezvillamor sgomezvillamor deleted the chore-drop-sqlparsingbuilder branch October 16, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants