Skip to content

Conversation

benjiaming
Copy link
Contributor

@benjiaming benjiaming commented Oct 14, 2025

Summary

  • fetch Product Updates notifications from the backend resolver
Screenshot 2025-10-14 at 4 18 36 PM

See also

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Oct 14, 2025
Copy link

alwaysmeticulous bot commented Oct 14, 2025

🔴 Meticulous spotted visual differences in 1 of 954 screens tested: view and approve differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit 574673a. This comment will update as new commits are pushed.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 14, 2025
Copy link

codecov bot commented Oct 14, 2025

Bundle Report

Changes will decrease total bundle size by 30.01kB (-0.1%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.56MB -30.01kB (-0.1%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -189 bytes 18.93MB -0.0%
assets/sample-*.png (Deleted) -29.82kB 0 bytes -100.0% 🗑️

Files in assets/index-*.js:

  • ./src/app/shared/product/update/hooks.ts → Total Size: 2.36kB

  • ./src/app/shared/product/update/ProductUpdates.tsx → Total Size: 3.21kB

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...b-web-react/src/app/shared/product/update/hooks.ts 33.33% 14 Missing ⚠️

📢 Thoughts on this report? Let us know!

"image": "https://raw.githubusercontent.com/datahub-project/datahub/master/metadata-service/configuration/src/main/resources/sample-product-update-image.png",
"ctaText": "Read updates",
"ctaLink": "https://docs.datahub.com/docs/releases#v1-2-1"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meticulous will fail until product-update.json is merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant