Preserve outer scalar allOf constraints

[Koudai Aono (koxudaxi)]

No description provided.

[coderabbitai]

Warning

Review limit reached

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 78257369-985d-430e-8def-4700784975e7

📥 Commits

Reviewing files that changed from the base of the PR and between 30a0e25 and 5341702.

⛔ Files ignored due to path filters (10)

• tests/data/expected/main/jsonschema/allof_outer_constraints/root_fields.txt is excluded by !tests/data/**/*.txt and included by none
• tests/data/jsonschema/allof_outer_constraints/description.json is excluded by !tests/data/**/*.json and included by none
• tests/data/jsonschema/allof_outer_constraints/length.json is excluded by !tests/data/**/*.json and included by none
• tests/data/jsonschema/allof_outer_constraints/minimum.json is excluded by !tests/data/**/*.json and included by none
• tests/data/jsonschema/allof_outer_constraints/multiple.json is excluded by !tests/data/**/*.json and included by none
• tests/data/jsonschema/allof_outer_constraints/number.json is excluded by !tests/data/**/*.json and included by none
• tests/data/jsonschema/allof_outer_constraints/ordinary.json is excluded by !tests/data/**/*.json and included by none
• tests/data/jsonschema/allof_outer_constraints/redundant.json is excluded by !tests/data/**/*.json and included by none
• tests/data/jsonschema/allof_outer_constraints/same_pattern.json is excluded by !tests/data/**/*.json and included by none
• tests/data/payloads/allof_outer_constraints.json is excluded by !tests/data/**/*.json and included by none

📒 Files selected for processing (34)

• src/datamodel_code_generator/parser/jsonschema.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/description_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/description_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/description_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/description_True_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/length_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/length_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/length_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/length_True_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/minimum_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/minimum_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/minimum_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/minimum_True_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/multiple_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/multiple_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/multiple_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/multiple_True_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/number_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/number_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/number_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/number_True_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/ordinary_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/ordinary_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/ordinary_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/ordinary_True_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/redundant_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/redundant_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/redundant_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/redundant_True_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/same_pattern_False_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/same_pattern_False_none.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/same_pattern_True_all.py
• tests/data/expected/main/jsonschema/allof_outer_constraints/same_pattern_True_none.py
• tests/main/jsonschema/test_allof_outer_constraints.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codspeed-hq]

Merging this PR will degrade performance by 10.92%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 4 regressed benchmarks
✅ 35 untouched benchmarks
⏩ 98 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
❌	test_perf_large_models_typed_dict[total-false-requiredness]	442.5 ms	501.4 ms	-11.74%
❌	test_perf_large_models_typed_dict[legacy-requiredness]	436.7 ms	490.4 ms	-10.95%
❌	test_perf_simple_pydantic_v2_field_construction	11 ms	12.3 ms	-10.59%
❌	test_perf_large_models_pydantic_v2_builtin_double_quotes	581.9 ms	649.4 ms	-10.39%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing fix/allof-root-outer-constraints (5341702) with main (22ee9fd)²}

Footnotes

1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on fix/allof-pattern-searches (30a0e25) during the generation of this report, so main (22ee9fd) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[github-actions]

📚 Docs Preview: https://pr-3946.datamodel-code-generator.pages.dev