Skip to content

Conversation

@joshdcu
Copy link

@joshdcu joshdcu commented Oct 23, 2025

Please see issue #82 for details

@allanger
Copy link
Member

I wanted to get rid of the v prefix for several years now, but never had enough will to actually do it, because I'm not sure how much of a breaking change it would be.

Regarding the pr, you need to bump the chart version, otherwise linter won't pass. But the question is, which version it should be. It seems like a breaking change to me, so maybe you need to bump the major one.

Actually, maybe I would remove the v prefix completely and as a temporary workaround would add it to the Chart.yaml to the app version, and with the next db-operator release, I would remove it completely from the tags.

And also, please add a note here: https://github.com/db-operator/charts/blob/main/charts/db-operator/templates/NOTES.txt

Just remove the content of "Breaking changes and migration paths:" and instead mention that if the tag was used in the values before, it should be now prefixed with v explicitly.

@joshdcu
Copy link
Author

joshdcu commented Oct 26, 2025

Thanks for your review! I'll make the changes you've mentioned soon 👍

- Bump Chart major version to 2.0.0
- Add notes on breaking change
- Add `v` prefix to Chart `appVersion` as temporary workaround
- Remove unnecessary Helm template related to image tag
- Completely override image tag using `.Values.image.tag`
@joshdcu joshdcu force-pushed the gh-82-image-tag-override branch from f65e370 to d570dea Compare October 27, 2025 07:05
@joshdcu
Copy link
Author

joshdcu commented Oct 27, 2025

you need to bump the chart version, otherwise linter won't pass. But the question is, which version it should be. It seems like a breaking change to me, so maybe you need to bump the major one.

Bumped to v2.0.0

maybe I would remove the v prefix completely and as a temporary workaround would add it to the Chart.yaml to the app version

Done!

please add a note here: https://github.com/db-operator/charts/blob/main/charts/db-operator/templates/NOTES.txt

Added a note there and also updated the README.md

@allanger
Copy link
Member

It seems like the tests are broken, but it shouldn't have anything to do with this PR, I'll have a look later

@allanger
Copy link
Member

allanger commented Nov 6, 2025

Thanks!

@allanger allanger merged commit c5cce3b into db-operator:main Nov 6, 2025
7 checks passed
@joshdcu joshdcu deleted the gh-82-image-tag-override branch November 6, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants