feat: custom select #3930
Merged
feat: custom select #3930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # packages/components/package.json # packages/components/src/components/select/model.ts # packages/components/src/utils/index.ts
# Conflicts: # package-lock.json # packages/components/package.json
…elect # Conflicts: # __snapshots__/foundations/chromium/Icons-should-match-screenshot-1/Icons-should-match-screenshot.png # __snapshots__/foundations/firefox/Icons-should-match-screenshot-1/Icons-should-match-screenshot.png # __snapshots__/foundations/webkit/Icons-should-match-screenshot-1/Icons-should-match-screenshot.png # __snapshots__/select/patternhub/select-docs-should-match-screenshot.png # packages/components/src/components/select/select.scss # packages/components/src/styles/internal/_form-components.scss # packages/foundations/scss/colors/_default-color-scheme.scss # showcases/e2e/default.ts
mfranzke
reviewed
Apr 14, 2025
mfranzke
reviewed
Apr 14, 2025
mfranzke
reviewed
Apr 14, 2025
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in UX Engineering Team Backlog
nmerget
added a commit
that referenced
this pull request
Apr 14, 2025
* feat: renamed border-height to border-width (#4000) * feat: adapt placeholder for input, textarea and select (#4012) * fix: add border to sub-navigation (#4029) * feat: add min-inline-size to input, select and textarea (#4011) * feat: angular signals (#4025) * feat: foundation update (#4002) * feat: badge and tag color adaption (#4041) * feat: custom select (#3930) --------- Co-authored-by: Michael Kraus <[email protected]> Co-authored-by: Maximilian Franzke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add new component
custom-selectfor:closes #3974
closes #3994
closes #4047
Types of changes
Further comments