Skip to content

Conversation

@nmerget
Copy link
Collaborator

@nmerget nmerget commented Mar 27, 2025

Proposed changes

closes #3888
closes #3344

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested a review from mfranzke as a code owner March 27, 2025 15:43
@nmerget nmerget enabled auto-merge (squash) March 27, 2025 15:43
@github-actions github-actions bot added 🧱components Changes inside components folder 📺showcases Changes to 1-n showcases labels Mar 27, 2025
@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-update-angular

@nmerget nmerget moved this to 👀 In review in UX Engineering Team Backlog Mar 27, 2025
@nmerget nmerget added this to the 2.0.0 milestone Mar 27, 2025
@mfranzke mfranzke changed the title Chore update angular chore: update angular Mar 27, 2025
@mfranzke mfranzke requested a review from Copilot March 28, 2025 09:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors several Angular components and related build scripts to update the Angular integration. Key changes include removing the standalone flag from multiple components, adjusting error message handling in components, and updating Angular-specific element overwrites in build scripts.

Reviewed Changes

Copilot reviewed 25 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
showcases/angular-showcase/src/app/components/switch/switch.component.ts Removed "standalone: true" from component metadata.
showcases/angular-showcase/src/app/components/select/select.component.ts Removed "standalone: true" from component metadata.
showcases/angular-showcase/src/app/components/radio/radio.component.ts Removed "standalone: true" from component metadata.
showcases/angular-showcase/src/app/components/input/input.component.ts Removed "standalone: true" and re-ordered metadata properties.
showcases/angular-showcase/src/app/components/home/home.component.ts Removed "standalone: true" from component metadata.
showcases/angular-showcase/src/app/components/form/wrapper/wrapper.component.ts Removed "standalone: true" from component declaration.
showcases/angular-showcase/src/app/components/form/radios/radios.component.ts Removed "standalone: true" from component declaration.
showcases/angular-showcase/src/app/components/form/form.component.ts Removed DefaultComponent from the imports array when using webComponents.
showcases/angular-showcase/src/app/components/checkbox/checkbox.component.ts Removed "standalone: true" from component metadata.
showcases/angular-showcase/src/app/app.component.ts Removed unused directive import from component metadata.
packages/components/src/shared/model.ts Updated model type key from _invalidMessageId to _invalidMessage.
packages/components/src/components/*.lite.tsx Adjusted invalidMessage handling to use computed state instead of props directly.
packages/components/scripts/post-build/components.ts Updated Angular element overwrite types for various components.
packages/components/scripts/post-build/angular.ts Modified ElementRef type replacement for Angular components.
Files not reviewed (3)
  • output/angular/package.json: Language not supported
  • showcases/angular-showcase/angular.json: Language not supported
  • showcases/angular-showcase/package.json: Language not supported
Comments suppressed due to low confidence (3)

showcases/angular-showcase/src/app/components/switch/switch.component.ts:15

  • Verify that removing 'standalone: true' does not lead to module declaration issues for this component.
-	standalone: true

showcases/angular-showcase/src/app/components/form/form.component.ts:31

  • Double-check that removing DefaultComponent from the webComponents imports array is intentional, as it could affect the component rendering or behavior.
-			DefaultComponent,

packages/components/scripts/post-build/angular.ts:17

  • Confirm that updating ElementRef to include '<HTMLElement | null>' aligns with all usages in the codebase and does not cause unexpected type issues.
return line.replace(': ElementRef', ': ElementRef<HTMLElement | null>');

@leape leape added this to Roadmap Apr 3, 2025
mfranzke
mfranzke previously approved these changes Apr 7, 2025
@nmerget nmerget requested a review from mfranzke April 7, 2025 07:14
@nmerget nmerget requested a review from mfranzke April 7, 2025 11:46
@nmerget nmerget merged commit 84927f7 into main Apr 7, 2025
73 checks passed
@nmerget nmerget deleted the chore-update-angular branch April 7, 2025 12:59
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧱components Changes inside components folder 📺showcases Changes to 1-n showcases

Projects

Status: No status
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

update Angular version to 19 update Angular version to 18

3 participants