-
Couldn't load subscription status.
- Fork 13
chore: update angular #3977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update angular #3977
Conversation
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/chore-update-angular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors several Angular components and related build scripts to update the Angular integration. Key changes include removing the standalone flag from multiple components, adjusting error message handling in components, and updating Angular-specific element overwrites in build scripts.
Reviewed Changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| showcases/angular-showcase/src/app/components/switch/switch.component.ts | Removed "standalone: true" from component metadata. |
| showcases/angular-showcase/src/app/components/select/select.component.ts | Removed "standalone: true" from component metadata. |
| showcases/angular-showcase/src/app/components/radio/radio.component.ts | Removed "standalone: true" from component metadata. |
| showcases/angular-showcase/src/app/components/input/input.component.ts | Removed "standalone: true" and re-ordered metadata properties. |
| showcases/angular-showcase/src/app/components/home/home.component.ts | Removed "standalone: true" from component metadata. |
| showcases/angular-showcase/src/app/components/form/wrapper/wrapper.component.ts | Removed "standalone: true" from component declaration. |
| showcases/angular-showcase/src/app/components/form/radios/radios.component.ts | Removed "standalone: true" from component declaration. |
| showcases/angular-showcase/src/app/components/form/form.component.ts | Removed DefaultComponent from the imports array when using webComponents. |
| showcases/angular-showcase/src/app/components/checkbox/checkbox.component.ts | Removed "standalone: true" from component metadata. |
| showcases/angular-showcase/src/app/app.component.ts | Removed unused directive import from component metadata. |
| packages/components/src/shared/model.ts | Updated model type key from _invalidMessageId to _invalidMessage. |
| packages/components/src/components/*.lite.tsx | Adjusted invalidMessage handling to use computed state instead of props directly. |
| packages/components/scripts/post-build/components.ts | Updated Angular element overwrite types for various components. |
| packages/components/scripts/post-build/angular.ts | Modified ElementRef type replacement for Angular components. |
Files not reviewed (3)
- output/angular/package.json: Language not supported
- showcases/angular-showcase/angular.json: Language not supported
- showcases/angular-showcase/package.json: Language not supported
Comments suppressed due to low confidence (3)
showcases/angular-showcase/src/app/components/switch/switch.component.ts:15
- Verify that removing 'standalone: true' does not lead to module declaration issues for this component.
- standalone: true
showcases/angular-showcase/src/app/components/form/form.component.ts:31
- Double-check that removing DefaultComponent from the webComponents imports array is intentional, as it could affect the component rendering or behavior.
- DefaultComponent,
packages/components/scripts/post-build/angular.ts:17
- Confirm that updating ElementRef to include '<HTMLElement | null>' aligns with all usages in the codebase and does not cause unexpected type issues.
return line.replace(': ElementRef', ': ElementRef<HTMLElement | null>');
Proposed changes
closes #3888
closes #3344
Types of changes
Further comments