Skip to content

feat(button): added possibility to set commandfor and command attributes #4408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

Enables implementation of #3322

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke self-assigned this Jun 24, 2025
@mfranzke mfranzke requested a review from nmerget as a code owner June 24, 2025 20:36
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jun 24, 2025
Copy link
Contributor

@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Jun 24, 2025
nmerget
nmerget previously approved these changes Jun 25, 2025
@nmerget nmerget enabled auto-merge (squash) June 26, 2025 07:42
@mfranzke mfranzke moved this from 👀 In review to 🏗 In development in UX Engineering Team Backlog Jun 26, 2025
@nmerget nmerget self-requested a review June 26, 2025 10:08
@nmerget
Copy link
Collaborator

nmerget commented Jun 26, 2025

The React types aren't ready for this feature. We need to add a custom interface IntrinsicElements to add it for react.

Is there any community member asking for this feature?

@nmerget nmerget marked this pull request as draft June 26, 2025 10:12
auto-merge was automatically disabled June 26, 2025 10:12

Pull request was converted to draft

@mfranzke
Copy link
Collaborator Author

The React types aren't ready for this feature. We need to add a custom interface IntrinsicElements to add it for react.

Is there any community member asking for this feature?

React doesn't seem to react on this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍄🆙improvement New feature or request
Projects
Status: 🏗 In development
Development

Successfully merging this pull request may close these issues.

2 participants