feat: add link property wrap #4540
Open
+102
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, add value "inline" for property variant - sets display: inline and removes arrow
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/feat-add-link-property-wrap |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
mfranzke
reviewed
Jul 17, 2025
There was a problem hiding this comment.
it looks like that the arrow is slightly off (vertically) due to the changes of this ticket, even though that I can't identify why this happens (based on the code changes being made).
mfranzke
reviewed
Jul 17, 2025
There was a problem hiding this comment.
show icon = false still does display an icon according to this screenshot, and the page https://design-system.deutschebahn.com/core-web/review/feat-add-link-property-wrap/components/action/link/overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
display: inlineand removes arrow.Closes #3995
Types of changes
Further comments
❤️ Thank you!