-
Notifications
You must be signed in to change notification settings - Fork 13
fix(docs): clicking the detail view link opens two new windows #4989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(docs): clicking the detail view link opens two new windows #4989
Conversation
|
…s-two-new-windows
Co-authored-by: Michael Kraus <[email protected]>
Pull request was converted to draft
…s-two-new-windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where clicking the detail view link in the React showcase was opening two new windows instead of one. The issue was caused by a combination of the onClick event handler and the href attribute both triggering navigation.
- Simplified URL generation logic by combining
getHrefandopenVariantInNewWindowfunctions - Removed the redundant
onClickevent handler that was causing duplicate window opens - Added proper
rel="noopener noreferrer"attribute for security
Pull request was converted to draft
…s-two-new-windows
…s-two-new-windows
Proposed changes
Resolves #4988
Types of changes
Further comments