Deprecate $MYSQL_UNIX_PORT environment variable#1720
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Deprecate $MYSQL_UNIX_PORT environment variable#1720rolandwalker wants to merge 1 commit intomainfrom
$MYSQL_UNIX_PORT environment variable#1720rolandwalker wants to merge 1 commit intomainfrom
Conversation
No correctness or security bugs stood out in the patch itself. I couldn’t run tests locally here because |
786d750 to
a2407e8
Compare
in favor of $MYSQL_UNIX_SOCKET. We can do this pretty freely since the feature was not documented. Motivation: a Unix Domain Socket is not a TCP/IP Port, though both are available on Unix and Unix-likes. The variable name was very confusing.
a2407e8 to
2128428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecate
$MYSQL_UNIX_PORTenvironment variable in favor of$MYSQL_UNIX_SOCKET. We can do this pretty freely since the feature was not documented.Motivation: a Unix Domain Socket is not a TCP/IP Port, though both are available on Unix and Unix-likes. The variable name was very confusing.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).