Support --username and environment variable to set username#1721
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Support --username and environment variable to set username#1721rolandwalker wants to merge 1 commit intomainfrom
--username and environment variable to set username#1721rolandwalker wants to merge 1 commit intomainfrom
Conversation
* make --username an alias for --user at the CLI * support an environment variable $MYSQL_USER which can be used in place of the CLI argument Rationale: we support both --pass and --password. The distinction between --user and --username is hard to remember. All other connection coordinates support an environment variable.
|
Findings
Actionable fix
Could not run tests locally because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--usernamean alias for--userat the CLI$MYSQL_USERwhich can be used in place of the CLI argumentRationale: we support both
--passand--password. The distinction between--userand--usernameis hard to remember. All other connection coordinates support an environment variable.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).