Add --batch option as an alternative to STDIN#1723
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Conversation
factoring out a statements_from_filehandle() function which can also be used to improve the functionality of the "source" command. The initial behavior when both STDIN is not-a-tty and --batch is in effect is to warn, and use --batch. Similarly, the priority of the --execute option was clarified with warnings. These may be revisited: we could consider different behavior, as well as exiting with an error in case of warning. Motivation: display of a prompt_toolkit progress bar during batch execution. If the input is from STDIN, we can't know how many statements are the goal, at least without creating a tempfile. As mentioned above, this also lays the basis to improve the "source" command, which reads the entire file into memory.
|
No correctness or security regressions stood out in the PR diff. Residual testing gaps (worth adding before merge):
I couldn’t run tests locally because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
--batchoption as an alternative to STDIN, factoring out astatements_from_filehandle()function which can also be used to improve the functionality of thesourcecommand.The initial behavior when both STDIN is not-a-tty and
--batchis in effect is to warn, and use--batch. Similarly, the priority of the--executeoption was clarified with warnings. These may be revisited: we could consider different behavior, as well as exiting with an error in case of warning.Motivation: display of a prompt_toolkit progress bar during batch execution. If the input is from STDIN, we can't know how many statements are the goal, at least without creating a tempfile. As mentioned above, this also lays the basis to improve the
sourcecommand, which reads the entire file into memory.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).