Security: Harden codex-review workflow against script injection#1728
Merged
rolandwalker merged 2 commits intodbcli:mainfrom Mar 19, 2026
Merged
Security: Harden codex-review workflow against script injection#1728rolandwalker merged 2 commits intodbcli:mainfrom
rolandwalker merged 2 commits intodbcli:mainfrom
Conversation
rolandwalker
approved these changes
Mar 19, 2026
Contributor
|
Thanks, @abhayclasher ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the security posture of the
codex-reviewworkflow by moving untrusted Pull Request metadata (title and body) into environment variables.Why this is necessary
Directly interpolating
${{ github.event.pull_request.title }}and${{ github.event.pull_request.body }}into a workflow step is a security risk, especially inpull_request_targetworkflows. This can lead to command injection if the underlying action or any shell scripts process these inputs. By using theenvcontext, we ensure the data is handled as a literal string, preventing arbitrary code execution within the runner context.Changes
run_codexstep to use theenvcontext forPR_TITLEandPR_BODY.promptargument to reference these environment variables.