Add Chrome logs display on test failure #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxr576
commented
Nov 11, 2025
.github/workflows/tests.yml
Outdated
|
|
||
| - name: Show Chrome logs when tests fails | ||
| shell: bash | ||
| # if: ${{ failure() }} |
Collaborator
Author
There was a problem hiding this comment.
Uncomment before merge.
Member
|
Thank you! |
Collaborator
Author
|
Okay, so as I expected this is not going to be a simple copy-paste due to the nature of how addon tests works. Will get back this PR later. |
Added a step to show Chrome logs on test failure.
mxr576
force-pushed
the
mxr576-patch-1
branch
2 times, most recently
from
b712794 to
c1731c6
Compare
Collaborator
Author
|
I had issues with setting up BATS on my local for running tests - different story, but I have proof that the following solution would work in the PR. Here is an intentionally failed build and selenium-chrome logs at end. https://github.com/ddev/ddev-selenium-standalone-chrome/actions/runs/19298600040/job/55186748888 |
Member
|
Bats is not hard. Happy to help you install it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a step to show Chrome logs on test failure.
This may help with debugging random test failures such as