feat: add create-novarnish-hosts command #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
task: add project name with project_tld host
rfay
reviewed
Apr 25, 2025
stasadev
reviewed
Jul 21, 2025
Comment on lines
+33
to
+39
| if ddev hostname --check $NOVARNISH_HOST 127.0.0.1 ; then | ||
| echo "Already in hostfile. Skipping..." | ||
| else | ||
| echo "Not present in hostfile." | ||
| echo "Executing 'ddev hostname $NOVARNISH_HOST 127.0.0.1'" | ||
| sudo ddev hostname $NOVARNISH_HOST 127.0.0.1 | ||
| fi |
There was a problem hiding this comment.
sudo no longer needed (it simply won't work, call ddev hostname without sudo) with DDEV v1.24.7+
Line 8 in 32ee3a5
However, it is possible that checking for VIRTUAL_HOST values should be DDEV's responsibility, not the add-on's.
Or at least the PR should implement this suggestion:
Shouldn't this try to figure out if the hostname is resolvable (if possible) instead of just adding things not in hosts file to hosts file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a host command to automate creation of
novarnish.*host entries if a customproject_tldoradditional_fqdnsare used.We have projects with a lot of additional_fqdns entries and thought this might be useful.