Skip to content

Conversation

KollPotato
Copy link
Contributor

Fixes #338.

Works on my machine, here is proof:

fixed.sidebar.video.mp4

Copy link
Member

@Robyt3 Robyt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it work on mobile?

@KollPotato
Copy link
Contributor Author

I have tested it in the dev tools on my desktop and also on my phone, works exactly like before.

@KollPotato
Copy link
Contributor Author

YouCut_20250823_191335036.mp4

@KollPotato
Copy link
Contributor Author

DON'T MERGE!!!! It does not behave as expected on some pages.

@ChillerDragon ChillerDragon marked this pull request as draft August 23, 2025 16:32
@KollPotato
Copy link
Contributor Author

I changed so if there is an overflow the sidebar is scrollable, otherwise no scrollbar is shown.

image image

@KollPotato KollPotato marked this pull request as ready for review August 23, 2025 16:54
@KollPotato KollPotato requested a review from Robyt3 August 29, 2025 16:37
@Robyt3
Copy link
Member

Robyt3 commented Aug 29, 2025

The navigation scrollbar overlapping the content doesn't look good to me. The scrollbar being visible with a common screen size like 1920x1080 also doesn't look good.

image

@KollPotato
Copy link
Contributor Author

KollPotato commented Aug 30, 2025

The scrollbar being visible with a common screen size like 1920x1080 also doesn't look good.

It is intentional that scrollbar only shows up when content doesn't fit screen height

@Robyt3
Copy link
Member

Robyt3 commented Aug 30, 2025

This now applies a transition: 0.4s; property to all elements, so the navigation position weirdly transitions when you resize the window, and highlighting of hovered links is barely visible anymore due to the slow transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fixed sidebar on homepage

2 participants