Chunked + background uploading #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: correct percentage of uploading is now being shown
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ddvleeuwen
requested changes
Jul 22, 2025
src/App.tsx
Outdated
|
|
||
| if ('SyncManager' in window) { | ||
| navigator.serviceWorker.ready.then((reg) => { | ||
| reg.sync.register('sync-uploads'); |
There was a problem hiding this comment.
Vercel geeft de volgende error op deze line:
src/App.tsx(20,25): error TS2339: Property 'sync' does not exist on type 'ServiceWorkerRegistration'.
There was a problem hiding this comment.
Not all browser support background uploading. See article: https://developer.mozilla.org/en-US/docs/Web/API/SyncManager
Added own definition based on mdn docs
src/services/challenge.service.tsx
Outdated
| const registration = await navigator.serviceWorker.ready; | ||
|
|
||
| if ('sync' in registration) { | ||
| registration.sync.register('sync-uploads'); |
There was a problem hiding this comment.
TS error here:
src/services/challenge.service.tsx(61,7): error TS18046: 'registration.sync' is of type 'unknown'.
There was a problem hiding this comment.
Not all browser support background uploading. See article: https://developer.mozilla.org/en-US/docs/Web/API/SyncManager
Added own definition based on mdn docs
Comment on lines
+102
to
+109
| await db.uploads.add({ | ||
| challengeId, | ||
| attemptId, | ||
| chunkIndex: String(chunkIndex), | ||
| fileName, | ||
| fileType, | ||
| data: await chunk.arrayBuffer(), | ||
| }); |
There was a problem hiding this comment.
Another typescript error somewhere along here.
src/services/challenge.service.tsx(51,7): error TS2322: Type 'number' is not assignable to type 'string'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.