Found while surveying old-architecture code for #457. Both verified.
docs/INTEGRATION_TESTING.md points at a deleted file
Lines 11 and 48 reference ArchitectureCompatibilityTest.kt, deleted in #434 along with ArchitectureSpecificTest.kt (637 lines of old-architecture detection, removed once the repo went new-architecture only). The doc still presents it as the way to verify architecture coverage, and gives a connectedAndroidTest --tests "*ArchitectureCompatibilityTest" command that now matches nothing.
The module name in that command is also stale — it says :siteed-expo-audio-studio, and the real one is :siteed_sherpa-onnx.rn.
PLAN.md:26 asserts something false
grep -r "ReactContextBaseJavaModule\|RCT_EXPORT_METHOD\|ReactPackage" packages/sherpa-onnx.rn/ returns nothing
It does not. SherpaOnnxModule extends ReactContextBaseJavaModule and SherpaOnnxPackage implements ReactPackage — both live and registered. Under RN 0.86's interop layer that is how the module registers, so the code is correct and the documentation is wrong.
This one has teeth: I nearly used that claim as evidence that the Kotlin module was dead. Running the grep is what stopped me.
Suggested
Rewrite both to describe what exists. A check that documented paths resolve would catch the first class of error cheaply — the second needs someone to re-run the assertion.
Related
Found while surveying old-architecture code for #457. Both verified.
docs/INTEGRATION_TESTING.mdpoints at a deleted fileLines 11 and 48 reference
ArchitectureCompatibilityTest.kt, deleted in #434 along withArchitectureSpecificTest.kt(637 lines of old-architecture detection, removed once the repo went new-architecture only). The doc still presents it as the way to verify architecture coverage, and gives aconnectedAndroidTest --tests "*ArchitectureCompatibilityTest"command that now matches nothing.The module name in that command is also stale — it says
:siteed-expo-audio-studio, and the real one is:siteed_sherpa-onnx.rn.PLAN.md:26asserts something falseIt does not.
SherpaOnnxModuleextendsReactContextBaseJavaModuleandSherpaOnnxPackageimplementsReactPackage— both live and registered. Under RN 0.86's interop layer that is how the module registers, so the code is correct and the documentation is wrong.This one has teeth: I nearly used that claim as evidence that the Kotlin module was dead. Running the grep is what stopped me.
Suggested
Rewrite both to describe what exists. A check that documented paths resolve would catch the first class of error cheaply — the second needs someone to re-run the assertion.
Related