Skip to content

Conversation

@maylad31
Copy link

As per haystack documents, PgvectorKeywordRetriever does not apply fuzzy search out of the box, so it's necessary to carefully formulate the query in order to avoid getting zero results. This tutorial will help people to understand how to improve the default implementation and how to better transform their query to avoid getting zero results.

@maylad31 maylad31 requested a review from a team as a code owner October 28, 2025 14:03
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bilgeyucel bilgeyucel self-requested a review October 28, 2025 14:30
@bilgeyucel
Copy link
Contributor

thanks @maylad31 for the notebook! I will review it this week

@maylad31
Copy link
Author

If anything else is needed from my side, please let me know. But I guess this could be a helpful notebook for people. Many use postgres and when all other things of the pipeline are working and so easy to set up, zero results for keyword search should not be a blocker. By the way it is a nice library and your cookbooks are amazing, would love to contribute more in future 🙂

@@ -0,0 +1,576 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just keep the title and the goal here. Also, give yourself credit for the work. Here's an example:

Improving PostgreSQL Keyword Search to Avoid Zero Results

Notebook by <your linkedin or github profile>

In this notebook, you'll learn how to extend the PgvectorDocumentStore implementation to better transform your query and avoid getting zero results.


Reply via ReviewNB

@@ -0,0 +1,576 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually dont need this section


Reply via ReviewNB

@@ -0,0 +1,576 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing Haystack


Reply via ReviewNB

@@ -0,0 +1,576 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this section completely


Reply via ReviewNB

Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the notebook @maylad31, It looks great! ❤️ I left some comments. After you resolved them, I'll add my commits (mainly around formatting) to this PR, if you dont mind :)

@maylad31
Copy link
Author

maylad31 commented Nov 7, 2025

Hi, I’ve pushed the changes you suggested. I hope everything looks good now.
Feel free to edit or adjust anything you think is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants