Submitting button value

[kim3er]

$.pjax.submit does not record the value of the submitting element.

On a standard form post, the value of the submitting button is passed along with the form data. This can be useful for describing the intent of a user.

For instance a form my have three submitting button; 'Save', 'Preview' or 'Publish'. The intent of the user can be established server side using the the button's value.

This is obviously not always a requirement, so $.pjax.submit is still a very useful function. However by attaching the handler to the submit event it is not possible, as far as I'm aware, to establish the value of the clicked button. This I assume is because the a form doesn't need a button in most browsers to fire that event.

So I have moved the logic from $.pjax.submit into and internal function called formSubmissionHandler and add an additional wrapper to the formSubmissionHandler called $.pjax.submitClick.

$.pjax.submitClick does the same as $.pjax.submit, but it is attached to the submitting elements of a form. This allows the submission handler to also identify the submitting element and record the value if one is present.

Rich

[kim3er]

Hi, is there any interest in this pull request? I've found very useful. Rich

[mislav]

Thanks for raising this issue. I believe that we should include the submit button name+value automatically, not with a special method. The pjax submit should send the form indentically as a browser would do natively.

I would take a look at this PR if it was done in a cleaner way. Take a look at how rails-behaviors detects submit buttons; we don't need to do absolutely the same approach (hidden element) but we do need something similar.

[kim3er]

Open new PR based on @mislav's comments. #390