Skip to content

Improve python connector test coverage #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve python connector test coverage #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions client/src/test/scala/io/delta/sharing/client/DeltaSharingRestClientSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ class DeltaSharingRestClientSuite extends DeltaSharingIntegrationTest {
Table(name = "deletion_vectors_with_dvs_dv_property_on", schema = "default", share = "share8"),
Table(name = "dv_and_cm_table", schema = "default", share = "share8"),
Table(name = "timestampntz_cdf_table", schema = "default", share = "share8")
Table(name = "add_columns_non_partitioned_cdf", schema = "default", share = "share8"),
Table(name = "add_columns_partitioned_cdf", schema = "default", share = "share8")
)
assert(expected == client.listAllTables().toSet)
} finally {
Expand Down
13 changes: 10 additions & 3 deletions python/delta_sharing/reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,17 +382,24 @@ def table_changes_to_pandas(self, cdfOptions: CdfOptions) -> pd.DataFrame:
response = self._rest_client.list_table_changes(self._table, cdfOptions)

schema_json = loads(response.metadata.schema_string)
converters = to_converters(schema_json)
schema_with_cdf = self._add_special_cdf_schema(schema_json)

if len(response.actions) == 0:
return get_empty_table(self._add_special_cdf_schema(schema_json))
return get_empty_table(schema_with_cdf)

converters = to_converters(schema_json)
pdfs = []
for action in response.actions:
pdf = DeltaSharingReader._to_pandas(action, converters, True, None)
pdfs.append(pdf)

return pd.concat(pdfs, axis=0, ignore_index=True, copy=False)
merged = pd.concat(pdfs, axis=0, ignore_index=True, copy=False)

col_map = {}
for col in merged.columns:
col_map[col.lower()] = col

return merged[[col_map[field["name"].lower()] for field in schema_with_cdf["fields"]]]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to preserve the column order?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and why does the column order matter?


def _copy(
self,
Expand Down
Loading
Loading