Skip to content

perf: speed up v8::String::to_rust_*_lossy() #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

perf: speed up v8::String::to_rust_*_lossy() #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fcb6a9
perf: speed up v8::String::to_rust_*_lossy()
lucacasonato Oct 18, 2024
2a2de45
try
lucacasonato Oct 25, 2024
ac7fadc
add method to ValueView
lucacasonato Oct 28, 2024
8baec0f
to_rust_cow_lossy
lucacasonato Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
sudo apt install -yq --no-install-suggests --no-install-recommends \
binfmt-support g++-10-aarch64-linux-gnu g++-10-multilib \
gcc-10-aarch64-linux-gnu libc6-arm64-cross qemu qemu-user \
qemu-user-binfmt
qemu-user-binfmt aarch64-linux-gnu-g++

sudo ln -s /usr/aarch64-linux-gnu/lib/ld-linux-aarch64.so.1 \
/lib/ld-linux-aarch64.so.1
Expand Down
11 changes: 11 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ use_custom_libcxx = []
bitflags = "2.5"
once_cell = "1.19"
paste = "1.0"
simdutf = "0.5.1"

[build-dependencies]
miniz_oxide = "0.7.2"
Expand Down
16 changes: 0 additions & 16 deletions src/binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,22 +1228,6 @@ void v8__String__ValueView__DESTRUCT(v8::String::ValueView* self) {
self->~ValueView();
}

bool v8__String__ValueView__is_one_byte(const v8::String::ValueView& self) {
return self.is_one_byte();
}

const void* v8__String__ValueView__data(const v8::String::ValueView& self) {
if (self.is_one_byte()) {
return reinterpret_cast<const void*>(self.data8());
} else {
return reinterpret_cast<const void*>(self.data16());
}
}

int v8__String__ValueView__length(const v8::String::ValueView& self) {
return self.length();
}

const v8::Symbol* v8__Symbol__New(v8::Isolate* isolate,
const v8::String* description) {
return local_to_ptr(v8::Symbol::New(isolate, ptr_to_local(description)));
Expand Down
Loading
Loading