-
Notifications
You must be signed in to change notification settings - Fork 354
native aarch64 builds #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
native aarch64 builds #1663
Conversation
0d478d9
to
bb314fe
Compare
bb314fe
to
fc55a6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
$basename = "sccache-$version-$platform" | ||
$url = "https://github.com/mozilla/sccache/releases/download/" + | ||
"$version/$basename.tar.gz" | ||
$url = "https://github.com/mozilla/sccache/releases/download/$version/$basename.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, can you help me understand, why use pwsh scripts to manually download sccache, instead of using the sccache-action ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all was written before that existed. Glad to know about it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with sccache-action in my fork repo: https://github.com/linrongbin16/rusty_v8/pull/2
The ci job failed on windows: https://github.com/linrongbin16/rusty_v8/actions/runs/14051568959
The error says 'sccahce' cannot compile 'syn' lib, and I search such kind of error, found this issue: mozilla/sccache#2196
So the conclusion is: sccache has a different behavior for rustc_wrapper
and server/client. So maybe keep it this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I submit PR #1748 to simplify the installtion of sccache
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - happy to land that patch if you can get it to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already finished the PR (and test many times), would you take a look?
we have a native linux aarch64 runner now, so we can use that instead of qemu :D