Skip to content

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Dec 4, 2024

we have a native linux aarch64 runner now, so we can use that instead of qemu :D

@devsnek devsnek force-pushed the x/native-aarch64-builds branch 2 times, most recently from 0d478d9 to bb314fe Compare December 4, 2024 16:40
@devsnek devsnek force-pushed the x/native-aarch64-builds branch from bb314fe to fc55a6a Compare December 4, 2024 16:47
@devsnek devsnek marked this pull request as ready for review December 4, 2024 17:42
@devsnek devsnek requested a review from bartlomieju December 4, 2024 17:43
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

$basename = "sccache-$version-$platform"
$url = "https://github.com/mozilla/sccache/releases/download/" +
"$version/$basename.tar.gz"
$url = "https://github.com/mozilla/sccache/releases/download/$version/$basename.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, can you help me understand, why use pwsh scripts to manually download sccache, instead of using the sccache-action ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all was written before that existed. Glad to know about it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with sccache-action in my fork repo: https://github.com/linrongbin16/rusty_v8/pull/2

The ci job failed on windows: https://github.com/linrongbin16/rusty_v8/actions/runs/14051568959

The error says 'sccahce' cannot compile 'syn' lib, and I search such kind of error, found this issue: mozilla/sccache#2196

So the conclusion is: sccache has a different behavior for rustc_wrapper and server/client. So maybe keep it this way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submit PR #1748 to simplify the installtion of sccache.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - happy to land that patch if you can get it to work

Copy link
Contributor

@linrongbin16 linrongbin16 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already finished the PR (and test many times), would you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants