Remove v8_enable_shared_ro_heap=false and v8_enable_verify_heap=false #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(as expected, this doesn't affect the release build at all, and sccache is even able to reuse all artifacts, so CI ran very quickly for release configurations) |
Open
|
I think we can land this now that we don't have two different snapshots in Deno, but this needs to be tested with deno_core and deno itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8_enable_shared_ro_heap is no longer configurable since v8/v8@b3054f7.
This also removes the justification for setting
v8_enable_verify_heap=falseso remove that too.