compliance/sancation_list_update_centralization

[mat-fs]

https://redmine.deriv.cloud/issues/70209

[raunakkathuria]

I would suggest naming it Data::Validate::Sanctions::Storage instead of Data::Validate::Sanctions::Redis. Redis is just a system that we are using, we may change this in future

[mat-fs]

This module is exclusively created for redis storage. It relies on hmget and hmset calls and cannot be written without references to Redis. A better alternative IMHO is to use the parent class Data::Validate::Sactions as a Factory that can create an object of this subclass with a code like this:

my $validator = Data::Validate:::Sanctions->new(storage => 'redis`, connection => $redis);

[chylli-deriv]

I guess you need install only redis-server
and if you want to install both , you can combine them:

Suggested change

	apt-get install -y redis && apt-get install -y redis-server
	apt-get install -y redis-server redis

[ragheb-deriv]

done

[chylli-deriv]

This line can & should be removed. dzil release will add it automatically

[chylli-deriv]

Will be better to use state here ?

[ragheb-deriv]

in some cases, the state declaration does not apply because we are using the internal scope of the variable in the set_sanction_file and the get_sanction_file subroutines.