- 
                Notifications
    You must be signed in to change notification settings 
- Fork 329
Fix: Honor COMPOSE_PROFILE environment variable #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            varkrish
  wants to merge
  1
  commit into
  devcontainers:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
varkrish:fix/compose-profile-handling
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    This commit addresses an issue where the `devcontainer exec` command would always override the `COMPOSE_PROFILE` environment variable by defaulting to `--profile *` when reading the Docker Compose configuration. The `readDockerComposeConfig` function in `src/spec-node/dockerCompose.ts` has been updated to check for the presence of the `COMPOSE_PROFILE` environment variable. If `COMPOSE_PROFILE` is set, the `--profile *` argument will not be added, allowing users to specify their desired profiles through the environment variable. Additionally, new tests have been added to `src/test/dockerComposeUtils.test.ts` to verify this behavior.
| @microsoft-github-policy-service agree
varun krishnamurthy… On Tue, Jul 1, 2025 at 12:13 PM microsoft-github-policy-service[bot] < ***@***.***> wrote:
 *microsoft-github-policy-service[bot]* left a comment
 (devcontainers/cli#1042)
 <#1042 (comment)>
 @varkrish <https://github.com/varkrish> please read the following
 Contributor License Agreement(CLA). If you agree with the CLA, please reply
 with the following information.
 @microsoft-github-policy-service agree [company="{your company}"]
 Options:
    - (default - no company specified) I have sole ownership of
    intellectual property rights to my Submissions and I am not making
    Submissions in the course of work for my employer.
 @microsoft-github-policy-service agree
    - (when company given) I am making Submissions in the course of work
    for my employer (or my employer has intellectual property rights in my
    Submissions by contract or applicable law). I have permission from my
    employer to make Submissions and enter into this Agreement on behalf of my
    employer. By signing below, the defined term “You” includes me and my
    employer.
 @microsoft-github-policy-service agree company="Microsoft"
 Contributor License Agreement Contribution License Agreement
 This Contribution License Agreement (*“Agreement”*) is agreed to by the
 party signing below (*“You”*),
 and conveys certain license rights to Microsoft Corporation and its
 affiliates (“Microsoft”) for Your
 contributions to Microsoft open source projects. This Agreement is
 effective as of the latest signature
 date below.
    1. *Definitions*.
    *“Code”* means the computer software code, whether in human-readable
    or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    *“Project”* means any of the projects owned or managed by Microsoft
    and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    *“Submit”* is the act of uploading, submitting, transmitting, or
    distributing code or other content to any
    Project, including but not limited to communication on electronic
    mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf
    of, the Project for the purpose of
    discussing and improving that Project, but excluding communication
    that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    *“Submission”* means the Code and any other copyrightable material
    Submitted by You, including any
    associated comments and documentation.
    2. *Your Submission*. You must agree to the terms of this Agreement
    before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now
    or in the future (except as
    described in Section 4 below), Submit to any Project.
    3. *Originality of Work*. You represent that each of Your Submissions
    is entirely Your original work.
    Should You wish to Submit materials that are not Your original work,
    You may Submit them separately
    to the Project if You (a) retain all copyright and license information
    that was in the materials as You
    received them, (b) in the description accompanying Your Submission,
    include the phrase “Submission
    containing materials of a third party:” followed by the names of the
    third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other
    instructions in the Project’s written
    guidelines concerning Submissions.
    4. *Your Employer*. References to “employer” in this Agreement include
    Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a
    contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your
    employer has intellectual
    property rights in Your Submission by contract or applicable law, You
    must secure permission from Your
    employer to make the Submission before signing this Agreement. In that
    case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You
    change employers in the future and
    desire to Submit additional Submissions for the new employer, then You
    agree to sign a new Agreement
    and secure permission from the new employer before Submitting those
    Submissions.
    5. *Licenses*.
    - *Copyright License*. You grant Microsoft, and those who receive the
    Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
    royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly
    display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all
    of the foregoing rights to third
    parties.
    - *Patent License*. You grant Microsoft, and those who receive the
    Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive,
    royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or
    the combination of the
    Submission with the Project to which it was Submitted to make, have
    made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the
    Project.
    - *Other Rights Reserved*. Each party reserves all rights not
    expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without
    limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
    6. *Representations and Warranties*. You represent that You are
    legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your
    original work (except as You may
    have disclosed under Section 3). You represent that You have secured
    permission from Your employer to
    make the Submission in cases where Your Submission is made in the
    course of Your work for Your
    employer or Your employer has intellectual property rights in Your
    Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You
    represent and warrant that You
    have the necessary authority to bind the listed employer to the
    obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless
    You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
    WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED
    UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO,
    ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
    7. *Notice to Microsoft*. You agree to notify Microsoft in writing of
    any facts or circumstances of which
    You later become aware that would make Your representations in this
    Agreement inaccurate in any
    respect.
    8. *Information about Submissions*. You agree that contributions to
    Projects and information about
    contributions may be maintained indefinitely and disclosed publicly,
    including Your name and other
    information that You submit with Your Submission.
    9. *Governing Law/Jurisdiction*. This Agreement is governed by the
    laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal
    courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in
    which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County,
    Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
    10. *Entire Agreement/Assignment*. This Agreement is the entire
    agreement between the parties, and
    supersedes any and all prior agreements, understandings or
    communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may
    be assigned by Microsoft.
 —
 Reply to this email directly, view it on GitHub
 <#1042 (comment)>,
 or unsubscribe
 <https://github.com/notifications/unsubscribe-auth/ATMD4QWUGPSUEU42D32WS7T3GHVFRAVCNFSM6AAAAACAPXEUV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMRRGQ3TQOBSG4>
 .
 You are receiving this because you were mentioned.Message ID:
 ***@***.***>
 | 
| What besides rebase is needed to get this merged? Would someone be willing to do the review if author or me rebase it? | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This commit addresses an issue where the
devcontainer execcommand would always override theCOMPOSE_PROFILEenvironment variable by defaulting to--profile *when reading the Docker Compose configuration.The
readDockerComposeConfigfunction insrc/spec-node/dockerCompose.tshas been updated to check for the presence of theCOMPOSE_PROFILEenvironment variable. IfCOMPOSE_PROFILEis set, the--profile *argument will not be added, allowing users to specify their desired profiles through the environment variable.Additionally, new tests have been added to
src/test/dockerComposeUtils.test.tsto verify this behavior.