Skip to content

[anaconda] - feature installation support for arm64/ aarch64. #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[anaconda] - feature installation support for arm64/ aarch64. #1342

wants to merge 16 commits into from

Conversation

Kaniska244
Copy link
Contributor

@Kaniska244 Kaniska244 commented Apr 21, 2025 •
edited
Loading

Ref# #1192

Description: The change is mainly done to to extend installation support of anaconda feature to arm64 architecture.

Changelog: The following files files are changed.

  • src/anaconda/install.sh - Change is done to extend support for arm64 architecture, upgrade the anaconda installation package version, fixing permissions & upgrading python packages for which older, vulnerable packages were installed. Also further changes made to extend this feature to support RHEL based linux distributions.
  • src/anaconda/devcontainer-feature.json - Version bump.
  • test/anaconda/install_anaconda_bookworm.sh - Added test script for anaconda installation on debian bookworm.
  • test/anaconda/install_anaconda_bullseye.sh - Added test script for anaconda installation on debian bullseye.
  • test/anaconda/install_anaconda_jammy.sh - Added test script for anaconda installation on ubuntu jammy.
  • test/anaconda/install_anaconda_noble.sh - Added test script for anaconda installation on ubuntu noble.
  • test/anaconda/install_anaconda_noble_without_user.sh - Added test script for anaconda installation on ubuntu noble without user in the input.
  • test/anaconda/scenarios.json - Added for all test cases.

Checklist:

  • Checked that applied changes work as expected.

@Mathiyarasy Mathiyarasy self-requested a review July 18, 2025 07:09
@Kaniska244 Kaniska244 marked this pull request as ready for review July 18, 2025 07:53
@Kaniska244 Kaniska244 requested a review from a team as a code owner July 18, 2025 07:53
@Kaniska244 Kaniska244 requested a review from Copilot July 25, 2025 05:24
Copilot

This comment was marked as outdated.

Sign in to view

@Kaniska244 Kaniska244 requested a review from Copilot July 25, 2025 06:33
Copilot

This comment was marked as outdated.

Sign in to view

@Kaniska244 Kaniska244 requested a review from Copilot July 25, 2025 07:17
Copilot
Copilot AI reviewed Jul 25, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the Anaconda feature to support ARM64/aarch64 architecture and RHEL-based Linux distributions. The main purpose is to broaden the platform compatibility of the devcontainer feature beyond the previously supported x86_64 Debian/Ubuntu systems.

Key Changes

  • Added ARM64/aarch64 architecture support to the Anaconda installer
  • Extended Linux distribution support to include RHEL-based systems (AlmaLinux, RockyLinux, Fedora)
  • Updated Anaconda version from 2021.11 to 2024.10-1 and added security package updates

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/anaconda/install.sh Core installation script enhanced with multi-architecture and multi-distro support, package manager detection, and security updates
src/anaconda/devcontainer-feature.json Version bump from 1.0.13 to 1.0.14
src/anaconda/README.md Updated documentation to reflect new OS support
test/anaconda/scenarios.json Added test scenarios for various Linux distributions
test/anaconda/*.sh Added test scripts for different distributions and architectures

AlvaroRausell
AlvaroRausell requested changes Jul 29, 2025
View reviewed changes
src/anaconda/README.md Outdated
Comment on lines 37 to 39
This Feature should work on recent versions of Debian/Ubuntu-based distributions with the `apt` package manager installed.

Also RHEL based linux distributions such as almalinux, rockylinux, fedora are supported now.
Please do note that Alpine and cbl-mariner aren't supported due system level restrictions with the anaconda installer in alpine linux and `groupadd`, `usermod`, `awk` commands not being supported in mariner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would turn this into a bullet-point list, just add a note about alpine and mariner, but not going into too much detail

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes and updated Notes.md as well. Kindly let me know in case of further corrections required.

@Kaniska244
Copy link
Contributor Author

Hello @AlvaroRausell ,

Thank you for the detailed review. I have done the corrections. Would you kindly have another look and let me know in case of any further corrections.

With Regards,
Kaniska

@Kaniska244 Kaniska244 requested a review from AlvaroRausell July 31, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@Mathiyarasy Mathiyarasy Mathiyarasy approved these changes

@AlvaroRausell AlvaroRausell Awaiting requested review from AlvaroRausell

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kaniska244 @AlvaroRausell @Mathiyarasy