Skip to content

Provide error response when failure occurs fetching Git tags #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eimhin-rover
Copy link

For the past 2 days we have observed the git feature failing to install on random occasions with the following error:

10.36 Invalid git version: latest
10.36 ERROR: Feature "Git (from source)" (ghcr.io/devcontainers/features/git) failed to install! Look at the documentation at ********/devcontainers/features/tree/main/src/git for help troubleshooting this error.

From looking into the source of the git feature I was able to identify where this error is stemming from and found that the curl used to fetch git tags does not have proper error handling.

As such, I have updated the install.sh script to improve the error handling here so that we fail earlier and can see the actual response from the curl to understand what the issue is.

My hunch is that there could be some kind of rate limiting happening so I'm curious also if anyone else has been seeing this issue.

@eimhin-rover eimhin-rover requested a review from a team as a code owner July 18, 2025 08:43
Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the contribution. Could you bump the patch version here please to 1.3.5?

@eimhin-rover
Copy link
Author

eimhin-rover commented Jul 21, 2025

Hey @AlvaroRausell! I've updated the version and also changed my approach. It seems that --fail-with-body is not available on older versions of curl, so I've opted for a different approach to ensure backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants