Skip to content

Conversation

pantierra
Copy link
Contributor

@pantierra pantierra commented Jul 3, 2025

@pantierra pantierra force-pushed the feature/container-startup-replacement branch 2 times, most recently from 72451e8 to 527178f Compare July 3, 2025 16:31
@pantierra pantierra marked this pull request as ready for review July 3, 2025 16:32
@pantierra pantierra requested a review from danielfdsilva July 3, 2025 16:32
@pantierra pantierra force-pushed the feature/container-startup-replacement branch 2 times, most recently from 37a8ae3 to ffc8047 Compare July 3, 2025 16:41
@pantierra pantierra force-pushed the feature/container-startup-replacement branch from ffc8047 to 831b714 Compare July 3, 2025 16:41
@pantierra pantierra requested a review from j08lue July 7, 2025 09:41
@pantierra
Copy link
Contributor Author

Just noticed. Are the theme variables:

  • REACT_APP_THEME_PRIMARY_COLOR or PRIMARY_COLOR
  • REACT_APP_THEME_SECONDARY_COLOR or SECONDARY_COLOR

@j08lue
Copy link
Member

j08lue commented Jul 7, 2025

Judging from the env example file, I think the former (with prefix):

# =================
# Theme Customization
# =================
# Primary color for the application theme (hex color code)
# Default: #6A5ACD (SlateBlue)
# REACT_APP_THEME_PRIMARY_COLOR='#6A5ACD'
# Secondary color for the application theme (hex color code)
# Default: #048A81 (Teal)
# REACT_APP_THEME_SECONDARY_COLOR='#048A81'

Copy link
Member

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the env vars need to include the prefix.

How can I best test this, please?

pantierra and others added 2 commits July 7, 2025 15:14
@pantierra
Copy link
Contributor Author

pantierra commented Jul 7, 2025

For testing you can build the docker container locally and run it with env variables.

E.g.

  • docker build -t stac-manager .
  • docker run --rm -it -e 'PUBLIC_URL=http://127.0.0.1:9000' -e 'REACT_APP_THEME_PRIMARY_COLOR=#000000' -p 127.0.0.1:9000:80 stac-manager

@pantierra pantierra requested a review from j08lue July 7, 2025 13:39
Copy link
Member

@danielfdsilva danielfdsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this system, the default colors need to be in the file

Co-authored-by: Daniel da Silva <[email protected]>
@pantierra
Copy link
Contributor Author

Thanks, added.

@pantierra pantierra merged commit 543283d into main Jul 8, 2025
4 checks passed
@pantierra pantierra deleted the feature/container-startup-replacement branch July 8, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants