-
Notifications
You must be signed in to change notification settings - Fork 93
chore: removing obsolete / deprecated EoL .Net 3.1, 5.0, 6.0 #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the lifecycle policy we have in place, we could start by adding the deprecated
tag in the stack and then after a 3 months period remove it.
In case we decide to keep open this PR, we need also to remove the records from the CODEOWNERS file:
Line 14 in fc77c5c
# .Net stacks |
@thepetk sorry, but why can't we just remove it? Runtime deprecation happened a long time ago on the Microsoft's end, and on the devfile.io landing page [1] you currently promote obsolete samples at the first place that probably no one is using - |
@ibuziuk as also discussed internally, according to our docs & policies in the end is up to the stack owner to decide that. As discussed @kadel (the dotnet stacks owner) is OK to remove them, so we can merge this one. |
@ibuziuk per your questions for the samples -> all samples are loaded from here: https://github.com/devfile/registry/blob/main/extraDevfileEntries.yaml Let me know if you need any further info from my side |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, kadel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Ilya Buziuk <[email protected]>
Signed-off-by: Ilya Buziuk <[email protected]>
Signed-off-by: Ilya Buziuk <[email protected]>
6624046
to
98d81d2
Compare
New changes are detected. LGTM label has been removed. |
@thepetk could you please point me where the tests are expected to be updated? |
/retest |
1 similar comment
/retest |
@ibuziuk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Seems persistent.. I'll have to open a ticket in the morning to see what's going on |
@michael-valdron @thepetk thank you for the follow-up. Just to clarify, there is nothing required from my end at this point, right? |
Description of Changes
Deprecation Status of .NET Versions
NET 3.1 was a Long-Term Support (LTS) release, but its support ended on December 13, 2022. Since then, it has been considered deprecated.
NET 5.0 was a Standard Term Support (STS) release, and its support ended much earlier, on May 10, 2022, making it a deprecated version. STS releases have a shorter lifecycle of 18 months.
NET 6.0 was also a Long-Term Support (LTS) release, but its support officially ended on November 12, 2024. This makes it a deprecated version.
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.