Skip to content

Conversation

vbakke
Copy link
Collaborator

@vbakke vbakke commented Sep 21, 2025

Let's try again. This time, creating a pull request (/merge request) into v4-dev. I decided to call this branch v4-dev so that we can reserve v4 to when we are ready to release.

assessment: activity.assessment.toString() || '',
level: activity.level || 0,
teamImplementation: activity.implementation || {},
// teamsEvidence: activity.teamsEvidence || {},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wurstbrot wrote:

is there a reason to not have teamsEvidence?

Nope. Thank you! 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this is part of the mapping.componentn.ts and we do not show any team progress or evidence on that page. That is why it was not included here.

@vbakke
Copy link
Collaborator Author

vbakke commented Sep 24, 2025

Added a new change, in the dependency graph:
image

Forgot to add support for dark mode, I just realised. I'll do that next...

@wurstbrot
Copy link
Collaborator

wurstbrot commented Sep 28, 2025

@vbakke I am not sure about "author" as an attribute due to data protection laws.
I added the others, see for example https://dsomm.owasp.org/assets/build-info.yaml

@wurstbrot
Copy link
Collaborator

At some point we might include a version in the data repository to the yaml. That is not so easy, because the activities.yaml/generated.yaml is not prepared for extra field (used to be in meta.yaml, which is moved to this repo)

@vbakke
Copy link
Collaborator Author

vbakke commented Sep 28, 2025

@vbakke I am not sure about "author" as an attribute due to data protection laws. I added the others, see for example https://dsomm.owasp.org/assets/build-info.yaml

The author is public in github anyway. But then again, it is not any need for that in my opinion, so that is fine to leave out author.

Just to verify: Is is regarding displaying version number and realse date of the DSOMM app, lets say on an About page, @wurstbrot ?

  • Will this file be produced whenever we merge to main?
  • And will this file also be included for peopler that run from docker, or clone the repo and run locally?

@vbakke
Copy link
Collaborator Author

vbakke commented Sep 28, 2025

At some point we might include a version in the data repository to the yaml. That is not so easy, because the activities.yaml/generated.yaml is not prepared for extra field (used to be in meta.yaml, which is moved to this repo)

EDIT: Moved my comment to a line in activities.yaml, to make a spearate thread that we may close:
#417 (comment)

@@ -0,0 +1,8911 @@
---
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning of DSOMM-data's activity-list

At some point we might include a version in the data repository to the yaml. That is not so easy, because the activities.yaml/generated.yaml is not prepared for extra field (used to be in meta.yaml, which is moved to this repo)

Yes, I know. I've tried to find a way, but I think I ended up with two suggestions, @wurstbrot.

A) treat meta in genetared.yaml/activities.yaml differently and extract this in the new LoaderService. (Small chance we will ever get a dimension called meta)

 meta:
   version: x.x.x.
   released: 2025-09-28
Build and Deployment:
  Build:
    Building and testing of artifacts in virtual environments:
    etc

B) use yaml's "multiple documents" feature. Something like:

---
meta:
  version: x.x.x.
  released: 2025-09-28
...
---
Build and Deployment:
 Build:
   Building and testing of artifacts in virtual environments:
   etc
...       

Both alternatives need an adjustment of in the LoaderService. But not a big change in the Angualr application

@vbakke
Copy link
Collaborator Author

vbakke commented Sep 28, 2025

Added a new change, in the dependency graph:

Forgot to add support for dark mode, I just realised. I'll do that next...

Dark mode added, @wurstbrot, @0x41head. And nodes ae now clickable, so that one can navigate between depending nodes. 🙂
(At least from the Matrix. The Heatmap does not yet have uuid as part of the URL when showing details. But foundation for this is now working : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants