Fix outdated angular warning #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nic McPhee <[email protected]>
Previously all that we did if there was an error in getting the users from the server was to do a `console.log()` and move on. This changes things so that we at least gives the user a simple error message. I feel like we should throw an error here as well so that there some stack info in the browser to debug with, but I can't figure out how to test that at the moment, so I'm going to leave it out. If someone knows how to make this work that would be great.
There was no real testing there, but there was enough code that it wasn't _obvious_ that there was no real testing. The UserCardComponent has zero meaningful logic, so I don't think there's any reason to even try, so I added a "test" that made that clear, removing all the other stuff.
I did this for my error handling in `UserListComponent`, but it might be useful elsewhere.
The Karma tests had gotten kinda random in places, and this is an effort to clean at least some of that up. I also added/extended comments in a number of places in an effort to try to make the code more instructive/informative. A _lot_ of the changes to UserServiceSpec are just white space and indentation. I added a bunch of `describe()`s in an attempt to better structure things, and that altered the indentation of just about everything.
These changes try to clarify a handful of small things in the write-up.
…ration-template Upgrade Javalin from v4 to v5.3.2 using the iteration template
Oops - in the process of refactoring, I wanted to use the name userArrayCaptor, but I couldn't have it twice. Looks like I forgot to delete the extra one I made in the process!
We must have really liked the name since we left it that way for a couple of years after changing from Spark to Javalin. Oops!
…ch-iteration-template
…n-template' into update-angular-to-match-iteration-template
Moving to Angular 15 and using Angular Material means we need this information
This is from the iteration and includes an attempt to find an alternative for @angular/flex-layout (along with some changes in the html itself that will come in a bit)
Take this file from the iteration template
This commit includes some rearranging of contents of files. Sometimes, I did this to address a specific warning. Other times, I rearranged to make things a bit more readable or to be consistent with the Iteration Template layout. There are some things in this commit that relate to getting rid of flex-layout.
We all do this from time to time when we are working on code, but it seemed like a good idea to remove or update documentation that doesn't match the code.
The matching of element names to actual things can be tricky with the updates to Angular 15 with the Angular Material components now using some mdc names. The formatting and syntax are a bit different in some places too.
Doesn't seem to break anything
This link has a redirect with a message about an updated name, so I fixed it. It's renaming the main branch to `main`.
Fix little errors
…n-template' into update-angular-to-match-iteration-template
Update LABTASKS and README of Lab 3 for Spring 23
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.25.2 to 2.27.5. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.25.2...v2.27.5) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…lient/eslint-plugin-import-2.27.5 Bump eslint-plugin-import from 2.25.2 to 2.27.5 in /client
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 16.18.12 to 18.13.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
I think that I removed this yesterday, and doing `npm install` in this branch brought it back. Does that mean we probably need it or want it?
…lient/types/node-18.13.0 Bump @types/node from 16.18.12 to 18.13.0 in /client
Bumps [cypress](https://github.com/cypress-io/cypress) from 9.4.1 to 12.5.1. - [Release notes](https://github.com/cypress-io/cypress/releases) - [Changelog](https://github.com/cypress-io/cypress/blob/develop/CHANGELOG.md) - [Commits](cypress-io/cypress@v9.4.1...v12.5.1) --- updated-dependencies: - dependency-name: cypress dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
I removed the confguration file and let Cypress generate a new one. Then, I added back the node event listeners that we previously had in the e2e part of the config file. This config file excludes the default config options whereas I think our old version was simply making those explicit even though we were using the defaults for almost everything.
…lient/cypress-12.5.1 Bump cypress from 9.4.1 to 12.5.1 in /client
Changed the warning in the README.md to match the current Angular version for the lab (15). I didn't remove it as a future proofing, in case that we don't upgrade from 15 right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty small change, but there was still a waring about using angular 13 in README.md, which now is updated to 15. I left the warning there, despite currently being on the current version in case we don't get around to upgrading immediately when 16 releases.