Skip to content

updating scoop template #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

updating scoop template #230

wants to merge 2 commits into from

Conversation

YashasviDevtron
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 27, 2024
View reviewed changes
charts/scoop/templates/deployment.yml
{{- end }}

containers:
- name: scoop-chart

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZBYC-63Dnc0ff4mZPyO-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBYC-63Dnc0ff4mZPyO&open=AZBYC-63Dnc0ff4mZPyO&pullRequest=230">SonarCloud</a></p>
charts/scoop/templates/deployment.yml
{{- if $.Values.labels }}
{{ toYaml $.Values.labels | indent 4 }}
{{- end }}
spec:

Check warning

Code scanning / SonarCloud

Service account tokens should not be mounted in pods

<!--SONAR_ISSUE_KEY:AZBYC-63Dnc0ff4mZPyP-->Set automountServiceAccountToken to false for this specification of kind Deployment. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBYC-63Dnc0ff4mZPyP&open=AZBYC-63Dnc0ff4mZPyP&pullRequest=230">SonarCloud</a></p>
charts/scoop/templates/clusterrole.yaml
- apiGroups:
- '*'
resources:
- '*'

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions

<!--SONAR_ISSUE_KEY:AZBYC-7WDnc0ff4mZPyQ-->Do not use wildcards when defining RBAC permissions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBYC-7WDnc0ff4mZPyQ&open=AZBYC-7WDnc0ff4mZPyQ&pullRequest=230">SonarCloud</a></p>
charts/scoop/templates/clusterrole.yaml
- apiGroups:
- extensions
resources:
- '*'

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions

<!--SONAR_ISSUE_KEY:AZBYC-7WDnc0ff4mZPyR-->Do not use wildcards when defining RBAC permissions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBYC-7WDnc0ff4mZPyR&open=AZBYC-7WDnc0ff4mZPyR&pullRequest=230">SonarCloud</a></p>
charts/scoop/templates/clusterrole.yaml
- apiGroups:
- apps
resources:
- '*'

Check warning

Code scanning / SonarCloud

Wildcards should not be used to define RBAC permissions

<!--SONAR_ISSUE_KEY:AZBYC-7WDnc0ff4mZPyS-->Do not use wildcards when defining RBAC permissions. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_charts&issues=AZBYC-7WDnc0ff4mZPyS&open=AZBYC-7WDnc0ff4mZPyS&pullRequest=230">SonarCloud</a></p>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

ajaydevtron
ajaydevtron requested changes Jun 28, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaydevtron ajaydevtron ajaydevtron requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YashasviDevtron @ajaydevtron