use offline sqlx by default - #152
Merged
Merged
Conversation
Make SQLx offline mode the default for normal development checks, while isolating live schema validation in a dedicated `sqlx:online-checks` task. Remote development environments previously had to build and install `sqlx-cli` from source before running the standard check suite. This made provisioning slow even though the application already commits SQLx query metadata. Normal formatting, linting, building, and testing now compile against the committed SQLx metadata in offline mode. Live database setup, migrations, and metadata validation are grouped into a dedicated online check that CI runs explicitly. This separates routine development from SQLx schema validation while preserving both offline-build coverage and protection against stale query metadata.
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
📝 WalkthroughWalkthroughSQLx runs in offline mode by default. The aggregate mise task no longer prepares the test database. A new 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SQLx offline mode the default for normal development checks while isolating live schema operations in dedicated tasks.
Remote development environments previously had to build and install
sqlx-clibefore running the standard check suite. This made provisioning slow even though the repository already commits SQLx query metadata.Formatting, linting, building, and testing now compile against committed metadata in offline mode.
sqlx:prepareregenerates metadata against a migrated test database, whilesqlx:prepare-checkvalidates it. CI runs the validation task explicitly.This separates routine development from live schema validation while preserving offline-build coverage and protection against stale query metadata.