Skip to content

use offline sqlx by default - #152

Merged
dhth merged 2 commits into
mainfrom
use-offline-sqlx-by-default
Aug 10, 2026
Merged

use offline sqlx by default#152
dhth merged 2 commits into
mainfrom
use-offline-sqlx-by-default

Conversation

@dhth

@dhth dhth commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Make SQLx offline mode the default for normal development checks while isolating live schema operations in dedicated tasks.

Remote development environments previously had to build and install sqlx-cli before running the standard check suite. This made provisioning slow even though the repository already commits SQLx query metadata.

Formatting, linting, building, and testing now compile against committed metadata in offline mode. sqlx:prepare regenerates metadata against a migrated test database, while sqlx:prepare-check validates it. CI runs the validation task explicitly.

This separates routine development from live schema validation while preserving offline-build coverage and protection against stale query metadata.

Make SQLx offline mode the default for normal development checks, while
isolating live schema validation in a dedicated `sqlx:online-checks`
task.

Remote development environments previously had to build and install
`sqlx-cli` from source before running the standard check suite. This
made provisioning slow even though the application already commits SQLx
query metadata.

Normal formatting, linting, building, and testing now compile against
the committed SQLx metadata in offline mode. Live database setup,
migrations, and metadata validation are grouped into a dedicated online
check that CI runs explicitly.

This separates routine development from SQLx schema validation while
preserving both offline-build coverage and protection against stale
query metadata.
@dhth

dhth commented Aug 10, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

SQLx runs in offline mode by default. The aggregate mise task no longer prepares the test database. A new sqlx:online-checks task creates the database, applies migrations, and validates SQLx metadata with online access. The main and pull request workflows invoke this task during testing. The locked setup no longer installs cargo:sqlx-cli.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: making SQLx offline mode the default.
Description check ✅ Passed The description accurately explains the offline default, dedicated online checks, and CI validation changes.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dhth
dhth merged commit 3acc0ca into main Aug 10, 2026
20 checks passed
@dhth
dhth deleted the use-offline-sqlx-by-default branch August 10, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant