fix(config.ts): fix config priority #275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getConfig function in config.ts has been updated to properly handle environment variables.
|
Stale pull request message |
|
hi @hydrotho great job! thank you! could you solve the hanging conflict and i merge it |
di-sukharev
approved these changes
Jul 4, 2024
|
should be fixed here there was a refactoring #391, please fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
In this project, according to the README documentation, local configuration should have a higher priority over the global configuration. However, in practice, it was observed that the local config wasn't overriding the global config as expected. Upon investigation, I identified that the issue originated from a logical error in the
getConfig()function in thesrc/commands/config.tsfile.Changes
To address this issue, I have made necessary modifications to the
getConfig()function. These changes ensure that the local config correctly overrides the global config.Testing and Validation
To validate the effectiveness of this fix, I conducted a series of tests including various combinations of global and local configurations. These tests have confirmed that the modified code now aligns with the expected behavior as described in our README.