Skip to content

Conversation

Ainias
Copy link

@Ainias Ainias commented Sep 21, 2025

Its basically the same PR as #252 but I added a check inside the setter.

Note that I only check for typeof dice !== 'object'
at first I had something like

if (!(dice instanceof StandardDice)){
  ...
}

but then I got dependency cycle errors of eslint and I don't think we can solve them without some serious redesign or ugly hacks. So I only included the typeof check

@Ainias Ainias requested a review from GreenImp as a code owner September 21, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant