base64 encode the content of GITHUB_APP_PRIVATE_KEY_BASE64

[NitriKx]

GITHUB_APP_PRIVATE_KEY_BASE64 expects to have the key base64-encoded.

If we do not encode there people can not copy paste the gh-app-key-file Base64 encoded content from the GitHub App creation wizard as is and need to base64 before.

[motatoes]

Hi @NitriKx thanks! But we already display b64 encoded private key in the wizard which is ready to copy and paste, so I don't see why we need to B64 again ?

[NitriKx]

It's because it's set as-is in the rendered manifest, meaning it will be "decoded" in the secret value. And this env var requires to have the pem Base64 encoded

[motatoes]

hey @NitriKx thanks for the clarification I tested it locally and you are right! Issue now is that test seem vailing because we are not setting a default value for it, we need to probably set it to "" in the .values part, in the interest of time I will merge this and fix the tests in the next PR